Fix test utility call checks in DSLX bytecode interpreter. - #4683
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Fix test utility call checks in DSLX bytecode interpreter.#4683copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Update `BytecodeEmitter` to associate the enclosing function (`source_fn`) with bytecode generated for expressions by traversing up the AST parent chain. Update `BytecodeInterpreter` to walk up the stack frames to find the caller function when checking if a test utility function is called from a test context. This ensures that helper calls nested inside expressions (e.g., in array size expressions) are correctly identified as coming from the enclosing function. Expand the test context check to allow calls from `#[test]` functions, `#[cfg(test)]` functions, and `#[test_proc]` configurations. PiperOrigin-RevId: 956043364
copybara-service
Bot
force-pushed
the
test_956043364
branch
from
July 29, 2026 20:39
5c7f8c8 to
8c31602
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test utility call checks in DSLX bytecode interpreter.
Update
BytecodeEmitterto associate the enclosing function (source_fn) with bytecode generated for expressions by traversing up the AST parent chain.Update
BytecodeInterpreterto walk up the stack frames to find the caller function when checking if a test utility function is called from a test context. This ensures that helper calls nested inside expressions (e.g., in array size expressions) are correctly identified as coming from the enclosing function.Expand the test context check to allow calls from
#[test]functions,#[cfg(test)]functions, and#[test_proc]configurations.