feat(ime): implement on_delete_surrounding_text v1 to v3 conversion - #33
Open
kkimdev wants to merge 1 commit into
Open
feat(ime): implement on_delete_surrounding_text v1 to v3 conversion#33kkimdev wants to merge 1 commit into
kkimdev wants to merge 1 commit into
Conversation
kkimdev
marked this pull request as ready for review
July 10, 2026 14:54
InternetOfTofu
self-requested a review
July 10, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #30 for easier review.
The v1 delete_surrounding_text handler was a no-op — it logged the call
but never forwarded it to the guest as a v3 delete_surrounding_text event.
Fix
Convert the v1 (index, length) semantics to v3 (before_length, after_length):
Changes