Refactor SerdeJson to use Arc and raw pointers for efficient sub-node access.#45
Open
copybara-service[bot] wants to merge 1 commit into
Open
Refactor SerdeJson to use Arc and raw pointers for efficient sub-node access.#45copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_944573884
branch
2 times, most recently
from
5b5547f to
c34cbd2
Compare
… access. The SerdeJson struct now holds an Arc to the root serde_json::Value and a raw pointer to the specific node it represents. This allows creating cheap views into sub-objects and array elements without deep cloning, improving performance for read operations. Mutation is restricted to the root node and is disallowed for sub-node views. PartialEq and Clone are updated to reflect this new structure. PiperOrigin-RevId: 944573884
copybara-service
Bot
force-pushed
the
test_944573884
branch
from
c34cbd2 to
bbdfc32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor SerdeJson to use Arc and raw pointers for efficient sub-node access.
The SerdeJson struct now holds an Arc to the root serde_json::Value and a raw pointer to the specific node it represents. This allows creating cheap views into sub-objects and array elements without deep cloning, improving performance for read operations. Mutation is restricted to the root node and is disallowed for sub-node views. PartialEq and Clone are updated to reflect this new structure.