Repository navigation
Fix non-constant format string in test server - #160
Open
HNO3Miracle wants to merge 1 commit into
Open
HNO3Miracle wants to merge 1 commit into
HNO3Miracle wants to merge 1 commit into
Conversation
Newer Go vet rejects non-constant format strings passed to fmt.Fprintf. Use fmt.Fprint because the test writes a prebuilt HTTP response body rather than a format string. This only changes test helper output and does not affect library behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
fmt.Fprintwhen writing a prebuilt HTTP response in the test server. The response is data rather than a format string, and current Go vet rejects passing it directly tofmt.Fprintf.Testing
go test -run '^$' ./...