feat: include package purls in JSON output#2885
Open
gotgolem wants to merge 4 commits into
Open
Conversation
another-rex
reviewed
Jun 27, 2026
another-rex
left a comment
Collaborator
There was a problem hiding this comment.
Apologies for the late review!
Im happy with the change overall, though I think the test that's added is a bit too complicated for what we're actually doing. I would say try to simplify the test or just remove it entirely.
We're currently a bit busy recently, so might be a little while before we can get this merge in, but I will try to make sure this change is in the next osv-scanner release.
Contributor
Author
|
@another-rex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #2874.
JSON output currently includes each scanned package's name, version, and ecosystem, but not its package URL.
This PR includes the package URL when scalibr provides one.
Details
I added an optional
purlfield toPackageInfoand populate it from scalibr's package URL inbuildVulnerabilityResults.The field is omitted (omitempty) when no PURL is available.
Testing
go test ./pkg/osvscannergo test ./internal/outputgo test ./pkg/models./scripts/run_lints.shChecklist
./scripts/run_lints.sh../scripts/run_tests.sh.