Skip to content

Handle 'k' suffix in video framerate parsing. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

Handle 'k' suffix in video framerate parsing. #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions mediapy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,8 +1331,16 @@ def _get_video_metadata(path: _Path) -> VideoMetadata:
if not (match := re.search(r', (\d+)x(\d+)', line)):
raise RuntimeError(f'Unable to parse video dimensions in line {line}')
width, height = int(match.group(1)), int(match.group(2))
if match := re.search(r', ([\d.]+) fps', line):
fps = float(match.group(1))
# Some videos have a 'k' suffix for kiloframes per second. Thus an extra
# `(k?)` is used for this case. This usually happens when we don't know
# the exact framerate. However, in order to not raise an error here, we
# will try to parse the framerate as x1000.
if match := re.search(r', ([\d.]+)(k?) fps', line):
number = float(match.group(1))
if match.group(2) == 'k':
fps = number * 1000
else:
fps = number
elif str(path).endswith('.gif'):
# Some GIF files lack a framerate attribute; use a reasonable default.
fps = 10
Expand Down
Loading