fix: add null check for file_saver in GenerateBinary to prevent null dereference#9161
Open
freinkxhihani-a11y wants to merge 1 commit into
Open
fix: add null check for file_saver in GenerateBinary to prevent null dereference#9161freinkxhihani-a11y wants to merge 1 commit into
freinkxhihani-a11y wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a null pointer check for
parser.opts.file_saverbefore dereferencingit in
GenerateBinary()insrc/idl_gen_binary.cpp.Problem
GenerateBinary()unconditionally dereferencesparser.opts.file_saverwithout verifying it is non-null. When the parser is initialized without
a valid file saver, this causes a null pointer dereference (SEGV).
This was discovered via OSS-Fuzz using the
codegen_fuzzertarget.Fix
Added an early return
if (!parser.opts.file_saver) return false;at the start of
GenerateBinary(), before any dereference occurs.Impact
Prevents a deterministic crash (SCARINESS: 10, null-deref) when
processing malformed .fbs schema files.