fix(flexbuffers): guard Map::Keys() against OOB heap read before buffer start#9159
Open
samrigby64 wants to merge 1 commit into
Open
fix(flexbuffers): guard Map::Keys() against OOB heap read before buffer start#9159samrigby64 wants to merge 1 commit into
samrigby64 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map::Keys()computesdata_ - byte_width_ * 3to locate the keys vector that precedes every FlexBuffers map in memory, but performs no check that the result is within the buffer allocation. A crafted FlexBuffer that places the map's data pointer withinbyte_width * 3bytes of the buffer start causes the subtraction to produce a pointer before the allocation — an out-of-bounds heap read.Root cause
Fix
Thread
buf_startfromGetRoot()throughReference(as an optional field defaulting tonullptr) intoMapviaAsMap(). Add a pre-flight check inKeys()that returnsEmptyTypedVector()if the backward offset would underflow:All existing constructors of
MapandReferenceare backward-compatible —buf_startdefaults tonullptr, which disables the guard. Only theGetRoot() → Reference → AsMap()path propagates the real buffer start.