Adapt to upstream rustc changes to AliasTyKind::def_id#1262
Closed
mvanbem-goog wants to merge 1 commit into
Closed
Adapt to upstream rustc changes to AliasTyKind::def_id#1262mvanbem-goog wants to merge 1 commit into
AliasTyKind::def_id#1262mvanbem-goog wants to merge 1 commit into
Conversation
rust-lang/rust#158013 It looks like the intent of these changes is that `AliasTyKind` will eventually gain variants that don't have a `DefId`. I'm not sure what we are going to do with that, but for now we can match on the variants, all of which do have a `DefId`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#158013
It looks like the intent of these changes is that
AliasTyKindwill eventually gain variants that don't have aDefId. We expect precisely one alias kind at this call site, so unpack that for itsDefId.