[Pending Validation] Return execution success status from load_bigquery_stats script - #5441
Open
stormKx18 wants to merge 2 commits into
Open
[Pending Validation] Return execution success status from load_bigquery_stats script#5441stormKx18 wants to merge 2 commits into
stormKx18 wants to merge 2 commits into
Conversation
dylanjew
approved these changes
Aug 27, 2026
dylanjew
left a comment
dylanjew
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, pending testing in dev!
dylanjew
approved these changes
Sep 3, 2026
dylanjew
reviewed
Sep 3, 2026
dylanjew
left a comment
dylanjew
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but please confirm testing in dev first!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
load_bigquery_statsdid not return a status, making it impossible for callers to know if the data was loaded successfully or if errors occurred.This PR updates
load_bigquery_statsto returnTrueif all fuzzer stats load successfully, andFalseif any errors or exceptions occur.Changes
load_bigquery_stats.py:Trueon success,Falseon failure.load_bigquery_stats_test.py:Trueon successful runs.Falseis returned when a BigQuery job fails.Unit tests
Code changes passed all the previous and new unit tests.
Validation
In progress.