stop truncating out-of-bmp identifier escapes in the scanner - #4337
Open
dxbjavid wants to merge 1 commit into
Open
stop truncating out-of-bmp identifier escapes in the scanner#4337dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out-of-range identifier escapes get silently truncated to a char
In
processUnicodeEscapesa braced unicode escape inside an identifier has its parsed code point cast straight to a char, so only the low 16 bits survive. That means an escape like \u{10041} is quietly accepted as the identifierA, and even values above the U+10FFFF maximum such as \u{110041} slip through the same way, so two identifiers that ought to be distinct (or rejected outright) can end up collapsing onto one. The scanner already rejects \u{10000} here, and the string-literal path range-checks the code point, so this brings identifiers into line by rejecting anything that does not fit in a char rather than aliasing it to a different character.