fix: preserve IME composition in Enter handlers - #471
Open
hugosmoreira wants to merge 1 commit into
Open
Conversation
hugosmoreira
marked this pull request as ready for review
July 27, 2026 17:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyCode === 229fallback used by the existing chat inputWhy
The main chat already protects CJK IME composition, but dialog and human-in-the-loop inputs still submitted when Enter was used to confirm a conversion candidate. This could send incomplete Japanese, Chinese, or Korean text.
Root cause
The affected Angular templates invoked their submit handlers without
$event, so the handlers could not inspectisComposing.Testing
npm test -- --watch=false --browsers=ChromeHeadlessCI— 585 tests passednpm run build— passedFixes #469