Repository navigation
fix: use McpTool inside McpToolset - #7472
Open
astrogilda wants to merge 1 commit into
Open
astrogilda wants to merge 1 commit into
astrogilda wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
McpToolset.get_tools()currently constructs the deprecatedMCPToolwrapper. That warns during normal use of the canonical toolset; treating deprecation warnings as errors prevents its tools from loading.Construct
McpTooldirectly. The basic toolset regression checks the exact canonical type with deprecation warnings treated as errors.Validation: all 432 MCP unit tests pass on Python 3.14. The regression fails on the unchanged upstream runtime with the expected constructor warning, then passes with this repair. Statement coverage for the changed runtime file is 97.07% against the existing 80% per-file gate. Pyink, isort, compliance and dependency checks pass.