Repository navigation
test: measure packages introduced by isolated imports - #7470
Open
astrogilda wants to merge 1 commit into
Open
astrogilda wants to merge 1 commit into
astrogilda wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isolated import checks include modules loaded by Python before the requested import. On Ubuntu's Python 3.12, that attributes
sitecustomizeto ADK and fails both entry-point allowlist checks.Capture the full module-name baseline before the statement and measure only names introduced afterward. The controls preload a startup package, then confirm that a new package and a new submodule of that package are still counted. The existing allowlist and absolute unloaded-module checks stay in force.
Validation: 26 import checks pass on Python 3.12 and 3.14. The changed measurement helper has 100% statement coverage against the existing 80% per-file gate. Pyink, isort and compliance checks pass.