Repository navigation
test: scope atexit cleanup assertions to their client - #7469
Open
astrogilda wants to merge 1 commit into
Open
astrogilda wants to merge 1 commit into
astrogilda wants to merge 1 commit into
Conversation
Count unregister calls for each registered callback by identity. Collect an older cyclic client inside the patched function and retain a live peer, then verify each owner separately and preserve repeated-close transport behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup tests count every process-wide
atexit.unregistercall. An older cyclic client can be collected during another client's close, producing a second call and a false failure.Match each call to its own registered callback by identity, keep a live peer, and check repeated close with a real HTTPX transport. The spy wraps
atexit.unregister, so the tests remove their real registrations.Validation: 29 client tests pass on Python 3.11 and 3.14. Pyink, isort and compliance checks pass.