Repository navigation
fix: preserve root task input across clarification turns - #7419
Open
vinitsonawane45 wants to merge 2 commits into
Open
vinitsonawane45 wants to merge 2 commits into
vinitsonawane45 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes root
LlmAgent(mode="task")losing its original task input after asking the user a clarification question.Root cause
Commit
ddbb59echanged task-mode root agents to use the generated node path as their isolation scope. This gave root invocations a fixed scope, such asreporting@1, allowing separate root task invocations in the same session to share the same scope.During task resumption, the original root user message could not be recovered through the existing function-call-based reconstruction because root tasks have no delegating function call.
Fix
target_node_name@ctx.invocation_idas the isolation scope for root task invocations.Tests
Regression coverage includes:
Validation
uv run pytest -v tests/unittests/workflow/test_task_api_e2e.py— 14 passed, 1 xfailed (previously reported).uv run pytest tests/unittests/a2a/integration/test_client_server_v1.py -v -k "test_a2a_task_clarification_and_resumption"— 1 passed, 16 deselected.uv run pyink --check tests/unittests/a2a/integration/test_client_server_v1.py— passed.git diff --check— passed.Fixes #7384