Fix docs, packaging, and minor code issues in gnm.shape#34
Open
manumishra12 wants to merge 1 commit into
Open
Conversation
- README: correct viewer filename (gnm_colab_viewer.py -> gnm_jupyter_viewer.py) and model data filename (gnm.npz -> gnm_head.npz) - pyproject: include data/**/*.txt so the landmark definition file (head_sparse_68.txt) is bundled on non-editable installs - gnm_jupyter_viewer.py: add the missing Apache-2.0 license header - gnm_utils: reference the existing 'variant' attribute instead of the non-existent 'model_type' in the region error message; fix "invidual" typo - gnm_data_loader: drop the stale commented-out import; fix "combinating" typo - semantic_sampler: ExpressionSampler docstring no longer claims to sample identities - gnm_tensorflow: correct attribute name in the GNM docstring (bone_aligned_template_joint_orientations)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #23, which GitHub auto-closed after a force-push that cleaned up
the branch. Same changes as #23, now without the accidentally committed
__pycache__/*.pycfiles, plus a small.gitignoreso they can't recur.gnm_jupyter_viewer.py) and model data filename (gnm.npz -> gnm_head.npz)
.gitignorefor__pycache__//*.py[cod]