refactor(angular): Remove redundant children normalization#1447
Open
josemontespg wants to merge 7 commits into
Open
refactor(angular): Remove redundant children normalization#1447josemontespg wants to merge 7 commits into
josemontespg wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ColumnComponent and RowComponent in the Angular renderer, simplifying their templates and removing logic related to child normalization and repeating templates. Feedback indicates that tracking by child.id in the @for loops may cause rendering issues due to non-unique IDs, suggesting child.basePath as a more robust alternative. Furthermore, the package-lock.json file includes extensive unrelated changes and noise that should be addressed or reverted to maintain a clean history and prevent unintended dependency updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(angular): Remove redundant children normalization
This PR removes the redundant
normalizedChildrencomputed property inRowComponentandColumnComponentin the Angular renderer.Reasoning
With better typing for
children(viaChildListSchemaandComponentBinder),this.props()['children'].value()already returns an array ofChildobjects (which haveidandbasePath).The normalization in
RowComponentandColumnComponentwas repeating whatComponentBinderalready does.Changes
normalizedChildren,isRepeating,templateId, andgetNormalizedPathfromRowComponentandColumnComponent.children()directly.This cleanup simplifies the code and avoids manual path manipulation in favor of the framework's path resolution.
TAG=agy
CONV=ae89267a-2379-4900-b1b3-53c073042795