Skip to content

Add v0.8 support to Angular explorer app#1436

Open
josemontespg wants to merge 20 commits into
google:mainfrom
josemontespg:angular-explorer-08-support
Open

Add v0.8 support to Angular explorer app#1436
josemontespg wants to merge 20 commits into
google:mainfrom
josemontespg:angular-explorer-08-support

Conversation

@josemontespg
Copy link
Copy Markdown
Collaborator

@josemontespg josemontespg commented May 14, 2026

This PR adds support for the v0.8 specification to the Angular explorer app. It includes a version toggle in the UI, updates the code generator to bundle v0.8 examples. Also refactors AgentStubService to be abstract, with different implementations based on the version.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the A2UI v0.8 specification in the Angular explorer. It refactors the AgentStubService into version-specific services, updates the DemoComponent to include a version selector and v0.8 theme support, and enhances the example generation script to handle multiple versions. Review feedback highlights several issues: a protocol mismatch in the v0.8 stub where parameters should be used instead of context, a performance anti-pattern involving sorting within a getter, and a bug in how v0.8 actions are logged. There are also suggestions to improve path parsing robustness and maintain type safety by avoiding any casts in catalog components.

Comment thread renderers/angular/a2ui_explorer/src/app/agent-stub.service.ts Outdated
Comment thread renderers/angular/a2ui_explorer/src/app/agent-stub.service.ts Outdated
Comment thread renderers/angular/a2ui_explorer/src/app/agent-stub.service.ts Outdated
Comment thread renderers/angular/a2ui_explorer/src/app/demo.component.ts Outdated
Comment thread renderers/angular/src/v0_9/catalog/basic/column.component.ts Outdated
Comment thread renderers/angular/src/v0_9/catalog/basic/row.component.ts Outdated
Copy link
Copy Markdown
Collaborator

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the agent-stub, are we trying to get logs from both 0.9 and 0.8 to be merged and work together nicely? I think we should reset the state of the app when switching protocol versions (and simplify all the code made to get things to work seamlessly :) )

Comment thread renderers/angular/scripts/generate-examples.mjs Outdated
Comment thread renderers/angular/scripts/generate-examples.mjs
Comment thread renderers/angular/a2ui_explorer/tsconfig.app.json Outdated
Comment thread renderers/angular/a2ui_explorer/src/app/agent-stub.service.ts Outdated
Comment thread renderers/angular/a2ui_explorer/src/app/agent-stub.service.ts Outdated
@josemontespg
Copy link
Copy Markdown
Collaborator Author

Refactored the code so that the version is resolved at page load, and a version change requires a full page reload. This way the code coupled to the specific version can be separated into independent files, making it easy to add/remove support for versions in the future, without changes to the main app.

@josemontespg josemontespg requested a review from ditman May 18, 2026 20:05
@josemontespg josemontespg marked this pull request as ready for review May 18, 2026 20:05
@josemontespg josemontespg enabled auto-merge (squash) May 18, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants