Add v0.8 support to Angular explorer app#1436
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for the A2UI v0.8 specification in the Angular explorer. It refactors the AgentStubService into version-specific services, updates the DemoComponent to include a version selector and v0.8 theme support, and enhances the example generation script to handle multiple versions. Review feedback highlights several issues: a protocol mismatch in the v0.8 stub where parameters should be used instead of context, a performance anti-pattern involving sorting within a getter, and a bug in how v0.8 actions are logged. There are also suggestions to improve path parsing robustness and maintain type safety by avoiding any casts in catalog components.
ditman
left a comment
There was a problem hiding this comment.
In the agent-stub, are we trying to get logs from both 0.9 and 0.8 to be merged and work together nicely? I think we should reset the state of the app when switching protocol versions (and simplify all the code made to get things to work seamlessly :) )
…plorer-08-support
|
Refactored the code so that the version is resolved at page load, and a version change requires a full page reload. This way the code coupled to the specific version can be separated into independent files, making it easy to add/remove support for versions in the future, without changes to the main app. |
This PR adds support for the v0.8 specification to the Angular explorer app. It includes a version toggle in the UI, updates the code generator to bundle v0.8 examples. Also refactors AgentStubService to be abstract, with different implementations based on the version.