Kotlin sdk recursive glob matching#1399
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a streaming A2UI parser for v0.8 and v0.9 specifications, featuring a new StreamingParser hierarchy and a TopologyAnalyzer for component reachability. It also enhances catalog management with message-level pruning and glob pattern support for loading examples. Review feedback identifies a critical argument swap in the AgentExtension constructor and several performance bottlenecks in the parser, including redundant regex compilations, inefficient list allocations in hot loops, and O(N^2) insertion operations.
jgindin
force-pushed
the
kotlin-sdk-recursive-glob-matching
branch
3 times, most recently
from
acfd580 to
e5e2a69
Compare
nan-yu
reviewed
May 12, 2026
jgindin
force-pushed
the
kotlin-sdk-recursive-glob-matching
branch
10 times, most recently
from
11b1ae9 to
b44e2d9
Compare
jgindin
force-pushed
the
kotlin-sdk-recursive-glob-matching
branch
3 times, most recently
from
4b4e191 to
6e022ef
Compare
Update loadExamples to support recursive glob pattern matching for loading examples, maintaining backward compatibility for directory paths and ensuring deterministic output order. Added robust automated unit tests in CatalogPruningTest.kt. Port of Python SDK commit 94c1c9b
jgindin
force-pushed
the
kotlin-sdk-recursive-glob-matching
branch
from
6e022ef to
12284b9
Compare
nan-yu
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update loadExamples to support recursive glob pattern matching for loading examples, maintaining backward compatibility for directory paths and ensuring deterministic output order. Added robust automated unit tests in CatalogPruningTest.kt.
Port of Python SDK commit 94c1c9b
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.