Skip to content

Kotlin sdk treeshake common types#1395

Merged
jgindin merged 1 commit into
google:mainfrom
jgindin:kotlin-sdk-treeshake-common-types
May 19, 2026
Merged

Kotlin sdk treeshake common types#1395
jgindin merged 1 commit into
google:mainfrom
jgindin:kotlin-sdk-treeshake-common-types

Conversation

@jgindin
Copy link
Copy Markdown
Collaborator

@jgindin jgindin commented May 11, 2026

Description

Treeshake common types schema

Port of Python SDK commit 1ea689d

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

@jgindin jgindin requested a review from nan-yu May 11, 2026 16:23
@jgindin jgindin self-assigned this May 11, 2026
@github-project-automation github-project-automation Bot moved this to Todo in A2UI May 11, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive streaming parser for A2UI, supporting both v0.8 and v0.9 specifications. Key additions include the StreamingParser hierarchy, a SchemaInspector for heuristic component detection, and a TopologyAnalyzer for reachability analysis. The A2uiCatalog was also updated with logic to prune unused common types. Review feedback highlights several critical performance concerns in the parser implementation, such as inefficient string concatenation in buffers, frequent regex compilation during metadata sniffing, and redundant serialization when tracking yielded components.

Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/core/parser/StreamingParser.kt Outdated
@jgindin jgindin force-pushed the kotlin-sdk-treeshake-common-types branch 3 times, most recently from 263339c to 6a1ba9c Compare May 12, 2026 15:51
@jgindin jgindin force-pushed the kotlin-sdk-treeshake-common-types branch 6 times, most recently from d26e2fe to 76aea88 Compare May 15, 2026 20:40
Port of Python SDK commit 1ea689d
@jgindin jgindin force-pushed the kotlin-sdk-treeshake-common-types branch from 76aea88 to d90c8e7 Compare May 19, 2026 16:21
@jgindin jgindin requested a review from nan-yu May 19, 2026 16:23
@jgindin jgindin merged commit db47eb6 into google:main May 19, 2026
18 checks passed
@jgindin jgindin deleted the kotlin-sdk-treeshake-common-types branch May 19, 2026 19:50
@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants