Repository navigation
Value-initialize WithReturnValue::retval in script/arg-packs.h. - #344
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
For scalar `Retval` types such as `bool` (used by `Equal`, `Verify`, `Isomorphic`, `Equivalent`, `RandEquivalent`, `TopSort`, `FarEqual`, `FarIsomorphic`, `Compress`, and `Decompress`), `WithReturnValue::retval` was left uninitialized on construction. When `Apply` fails to find a registered operation on the given arc type in non-fatal mode (`--fst_error_fatal=false`), it returns without invoking the operation and callers read an uninitialized `retval`.
Value-initialize `Retval retval{};` in `WithReturnValue` (`script/arg-packs.h`).
PiperOrigin-RevId: 994606927
copybara-service
Bot
force-pushed
the
copybara/994606927
branch
from
October 7, 2026 11:50
9b49dfa to
4245db5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value-initialize
WithReturnValue::retvalinscript/arg-packs.h.For scalar
Retvaltypes such asbool(used byEqual,Verify,Isomorphic,Equivalent,RandEquivalent,TopSort,FarEqual,FarIsomorphic,Compress, andDecompress),WithReturnValue::retvalwas left uninitialized on construction. WhenApplyfails to find a registered operation on the given arc type in non-fatal mode (--fst_error_fatal=false), it returns without invoking the operation and callers read an uninitializedretval.Value-initialize
Retval retval{};inWithReturnValue(script/arg-packs.h).