Repository navigation
Reset unpinned states and erase hits in NoGcKeepOneExpanderCache. - #336
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
copybara/993745190
branch
2 times, most recently
from
October 6, 2026 17:57
b9bc0e0 to
27967a8
Compare
In `NoGcKeepOneExpanderCache::FindOrExpand`, once any pinned state (`ref_count_ > 0`) was moved into `cache_`, `cache_.empty()` remained false. When subsequently visiting an unpinned state (`ref_count_ == 0`) followed by another uncached state, `state_` stayed non-null and `FindOrExpand` returned `state_.get()` without resetting or expanding the new state, serving stale arcs from the prior unpinned state. In addition, cache hits moved the `std::unique_ptr<State>` out of `cache_` without erasing the map entry, leaving null entries in `cache_` indefinitely. When `cache_` hits, move the cached state into `state_`, erase the map entry, and return immediately. On a cache miss, allocate `state_` if null or call `state_->Reset()` when reusing an unpinned state, then expand the requested state. PiperOrigin-RevId: 994511676
copybara-service
Bot
force-pushed
the
copybara/993745190
branch
from
October 6, 2026 18:18
27967a8 to
df1c76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset unpinned states and erase hits in NoGcKeepOneExpanderCache.
In
NoGcKeepOneExpanderCache::FindOrExpand, once any pinned state (ref_count_ > 0) was moved intocache_,cache_.empty()remained false. When subsequently visiting an unpinned state (ref_count_ == 0) followed by another uncached state,state_stayed non-null andFindOrExpandreturnedstate_.get()without resetting or expanding the new state, serving stale arcs from the prior unpinned state. In addition, cache hits moved thestd::unique_ptr<State>out ofcache_without erasing the map entry, leaving null entries incache_indefinitely.When
cache_hits, move the cached state intostate_, erase the map entry, and return immediately. On a cache miss, allocatestate_if null or callstate_->Reset()when reusing an unpinned state, then expand the requested state.