Conversation
xkxx
marked this pull request as ready for review
October 1, 2026 04:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formalize grouped tokens across all top-level token categories (
colors,typography,spacing, androunded) so design systems can organize theme modes (e.g.,lightanddark), responsive breakpoints (recommended:sm,md,lg,xlfor mobile, tablet, laptop, and desktop), and hierarchical token families without flattened naming boilerplate.Changes
ModelHandlerto traverse nested group sub-maps and enforce flat-vs-grouped collision detection fortypographytokens, matching existingcolors,spacing, androundedbehavior.docs/spec.md) andREADME.mdto document generic grouped token sub-maps, dot-path token references (e.g.,{colors.light.surface},{typography.sm.headline-lg},{spacing.lg.gutter}), collision detection rules, and recommended group names (light/darkfor themes;sm/md/lg/xlfor responsive breakpoints).