fix(cli): reject non-finite numbers in settings editor

[bunnysayzz]

Fixes #29226.

parseEditedValue('number', ...) only rejected NaN, so overflow input like 1e309 parsed to Infinity, passed validation, and JSON serialization silently stored it as null — corrupting the setting the dialog had just accepted. Number.isFinite covers NaN and both infinities; returning null makes the dialog keep the existing value (it already early-returns on null in handleEditCommit).

Tests: new parseEditedValue > number block (finite, empty, non-numeric, and the 1e309/Infinity/-Infinity regression cases — the regression test fails pre-fix). settingsUtils.test.ts: 53 passed. eslint + prettier clean.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a data corruption issue in the settings editor where overflow values were being accepted as valid input. By switching to a stricter finite number check, the application now prevents non-finite values from being processed, ensuring that the settings remain consistent and preventing serialization errors.

Highlights

• Validation Logic Update: Updated the parseEditedValue function to use Number.isFinite instead of Number.isNaN, ensuring that non-finite numbers like Infinity are correctly rejected.
• Regression Testing: Added comprehensive unit tests in settingsUtils.test.ts to verify that finite numbers are accepted and non-finite inputs are properly handled.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

📊 PR Size: size/S

• Lines changed: 29
• Additions: +28
• Deletions: -1
• Files changed: 2

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Code Review

This pull request updates the parseEditedValue utility function in packages/cli to use !Number.isFinite(numParsed) instead of Number.isNaN(numParsed). This ensures that non-finite numeric values (such as Infinity, -Infinity, and overflow values like 1e309) are correctly rejected and treated as invalid (returning null), preventing potential serialization issues. Corresponding unit tests have been added to verify this behavior. I have no feedback to provide.

[gemini-cli]

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'.

This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding.

[bunnysayzz]

Rebased onto latest main (was 9 behind, clean, upstream never touched these files). This push should also retrigger the CLA check: I have now signed the Google CLA, so cla/google should flip green on this run.