Skip to content

Cleanup protocols naming and convert Union types to Protocols. #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleanup protocols naming and convert Union types to Protocols. #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gemma/diffusion/hackable_diffusion_adapter/hd/hd_gemma_ar_state_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
Tokens = Int["*B L"]
Conditioning = hd_typing.Conditioning
DataArray = hd_typing.DataArray
DiffusionStepTree = hd.sampling.DiffusionStepTree
DiffusionStepTree = hd_typing.PyTree[hd.sampling.DiffusionStep]


################################################################################
Expand Down
6 changes: 3 additions & 3 deletions gemma/diffusion/hackable_diffusion_adapter/hd/hd_gemma_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
TargetInfoTree = hd_typing.TargetInfoTree


BaseDiffusionNetwork = diffusion_network.BaseDiffusionNetwork
DiffusionNetwork = diffusion_network.DiffusionNetwork

DiffusionGemmaModel = gemma_diffusion.DiffusionGemma_26B_A4B

Expand Down Expand Up @@ -112,8 +112,8 @@ def prefill_kv_cache_with_encoder(
################################################################################


class WrappedDiffusionGemmaNetwork(nn.Module, BaseDiffusionNetwork):
"""Wraps a Diffusion Gemma model as an HD ``BaseDiffusionNetwork``.
class WrappedDiffusionGemmaNetwork(nn.Module, DiffusionNetwork):
"""Wraps a Diffusion Gemma model as an HD ``DiffusionNetwork``.

The wrapper handles the hackable diffusion interfaces and Gemma specifics. For
self conditioning, it uses `call_with_self_conditioning` function from Gemma.
Expand Down
Loading