Fix missing f-prefix in _normalize_token error message#722
Open
HumphreySun98 wants to merge 1 commit into
Open
Fix missing f-prefix in _normalize_token error message#722HumphreySun98 wants to merge 1 commit into
HumphreySun98 wants to merge 1 commit into
Conversation
The ValueError raised in _normalize_token() when a stop/forbidden token
does not map to a single token id used a plain string, so the {token!r}
placeholder was emitted literally instead of the offending token value,
making misconfigurations hard to debug.
Add the missing f-prefix and a regression test asserting the message
names the token.
Fixes google-deepmind#658
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_normalize_token()ingemma/gm/text/_sampler.pyraises aValueErrorwhen a
stop_token/forbidden_tokenstring does not map to a singletoken id. The message string was missing its
fprefix, so{token!r}was printed literally instead of interpolating the offending token,
making these misconfigurations hard to debug.
Fixes #658.
Change
The second (implicitly concatenated) line has no placeholders, so it is
left unchanged.
Testing
Added
test_normalize_token_error_message_includes_token, which drives theerror path with a fake tokenizer and asserts the message names the token.
Verified it is a real regression guard — it fails on the pre-fix code
and passes with the fix.