Preserve the channel axis in HSL conversions - #125
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve
channel_axisin both HSL conversions. The functions currently split the requested input axis but always stack their output on the last axis;hsl_to_rgbalso assumes channels-last when broadcasting achromatic pixels.Use the requested axis for both stacking and broadcasting. Add comparisons with Python's
colorsysacross positive/negative axes, batched images, gray/color pixels, and eager/JIT execution.Validation
JAX_PLATFORMS=cpu python -m pytest -q -n 2 dm_pix1,362 passed, 99 skipped. On unpatched master, 24 new cases fail and the 8 channels-last controls pass.
git diff --checkpasses. No GPU/TPU execution was run.