deps: unpin pydantic, bump wandb 0.21.0 -> 0.22.3#935
Open
ocg-goodfire wants to merge 1 commit into
Open
Conversation
The pydantic pin (#232) only silenced wandb's UnsupportedFieldAttributeWarning spam under pydantic 2.12+ (#221). wandb fixed that in wandb/wandb#10651, first released in v0.22.3, so the pin can go once wandb is on a fixed release. Locks pydantic at 2.13.4. Verified: importing wandb + the config schema is clean under warnings-as-errors with wandb 0.22.3 / pydantic 2.13.4 (wandb 0.21.0 emits 6 warnings), and the full non-slow suite passes (458 passed). Closes #233 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
pydantic<2.12pin (back to the pre-pinpydantic>=2) and bumpswandb==0.21.0→wandb==0.22.3. Lockfile now resolves pydantic 2.13.4 (current latest).The wandb bump is load-bearing: the warnings the pin silenced come from wandb's own use of pydantic
Field(), fixed upstream in wandb/wandb#10651 and first released in v0.22.3 — our pinned 0.21.0 predates it, so removing the pydantic pin alone would bring the spam back. 0.22.3 is the minimal fixed release (deliberately not jumping to current 0.28.0; further wandb bumps are a separate concern).Related Issue
Closes #233 (and re-resolves #221 without the pin)
Motivation and Context
The pin was always meant to be temporary ("remove once wandb fixes it") — wandb shipped the fix in Oct 2025.
How Has This Been Tested?
UnsupportedFieldAttributeWarningon import; wandb 0.22.3 / 0.28.0 → zero warnings.import wandb+param_decomp.configs+param_decomp.built_runclean underwarnings.simplefilter("error")with the new lock.make type(basedpyright): 0 errors — the pinnedbasedpyright<1.32.0is still fine with wandb 0.22.3 (that pin is a separate pyright issue, left untouched).Does this PR introduce a breaking change?
No.
🤖 Generated with Claude Code