docs(pretrain): fix stale clean_suffix_logits reference missed by #923#930
Open
ocg-goodfire wants to merge 1 commit into
Open
docs(pretrain): fix stale clean_suffix_logits reference missed by #923#930ocg-goodfire wants to merge 1 commit into
ocg-goodfire wants to merge 1 commit into
Conversation
…round-trip is clean_output Last prose straggler from the residual-start removal missed by #923. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fast-follow to #923's prefix/suffix terminology sweep.
param_decomp_lab/experiments/lm/pretrain/CLAUDE.mdstill claimed the pretrain forward is pinned bit-identical to the loader'sclean_suffix_logitsround-trip — that symbol died with the residual-start removal (3883362). The pinning test (param_decomp/tests/test_pretrain.py::test_cache_round_trip_matches_decomposition_loader) compares againsttarget.clean_output(idx); the prose now says so.Verified this is the last dead-design straggler on
feature/jax: a fresh grep of the tip finds only live meanings (chunkwise-scan frozen prefix/suffix in llama8b.py, string/module-name prefixes,path.suffix, linguistic "##ing suffix") plus the intentionally-lefttests/equivalence+stacked_parityfixture prose, which belongs to the xfailed residual-fed goldens pending embed-internal regen.🤖 Generated with Claude Code