Authorized dash and numbers in domain name for rewrite cookies#56
Open
xdejonghe-viseo wants to merge 1 commit into
Open
Authorized dash and numbers in domain name for rewrite cookies#56xdejonghe-viseo wants to merge 1 commit into
xdejonghe-viseo wants to merge 1 commit into
Conversation
…numbers characters
Author
|
I change my commit to remove the file about my editor configuration (.idea) |
Author
|
Notice, that the regex used to rewrite domain name authorizes to start the domain name by a dash and that is not permitted in RFC 952 |
|
will this merge one day? :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I propose you to authorize dashes and numbers in the regexp used to rewrite the domain name in cookies.
Thanks for your excellent plugin.