Streaming and raw response support - #14
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 32 33 +1
Lines 990 1328 +338
==========================================
+ Hits 990 1328 +338 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
feat: per-call and per-method middleware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added HTTPResponse.raise_for_status().
Added raw response support in HTTPRequest.
Added support for the stream method.
Replaced deprecated urllib.getcode() with raw.status.
AsyncMock() without spec made the sync build_request async too, leaking an unawaited coroutine. Add spec=httpx(2).AsyncClient so only send() is async.
A shared client couldn't serve consumers with different auth, since middleware came only from self.middleware. Now call_method and call_method_stream take a keyword-only middleware= binds middleware to an endpoint. Both append rather than replace, outermost first: self.middleware -> per-call.
Type of change
Checklist
just lintshows no errors)just static-analysis