Skip to content

Bail if script helper class does not exist #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agibson-godaddy merged 1 commit into from
May 18, 2026
+6 −0
Merged

Bail if script helper class does not exist #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions woocommerce/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*** SkyVerge WooCommerce Plugin Framework Changelog ***

2026.nn.nn - version 6.2.1
* Fix - Protect against `ScriptHelper` fatal errors on plugin upgrades

2026.04.16 - version 6.2.0
* New - Added REST API support to Abilities for automatic route registration
Expand Down
5 changes: 5 additions & 0 deletions woocommerce/class-sv-wc-admin-notice-handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ public function render_admin_notice_js() {
return;
}

// Bail if the script helper class does not exist. This can occur in the middle of plugin upgrades.
if (! class_exists(ScriptHelper::class)) {
Comment thread
agibson-godaddy marked this conversation as resolved.
return;
}

$plugin_slug = $this->get_plugin()->get_id_dasherized();

self::$admin_notice_js_rendered = true;
Expand Down