clifecycle: add SetStopTimeout to make the shutdown grace period configurable - #11
Open
ironAtom wants to merge 1 commit into
Open
clifecycle: add SetStopTimeout to make the shutdown grace period configurable#11ironAtom wants to merge 1 commit into
ironAtom wants to merge 1 commit into
Conversation
…igurable Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lifecycle.StopwaitsdefaultStopTimeout(a hardcoded 30s) for background goroutines before running cleanup funcs and canceling the lifecycle context. Apps whose background work is bounded by a deadline of similar length (e.g. a job runner whose per-job timeout is also 30s) have zero margin: work claimed just before shutdown can be force-quit right as it is about to finish.This adds
Lifecycle.SetStopTimeout(d time.Duration)so apps can raise the grace period above their own work deadline. Default behavior is unchanged.Test plan
go build ./clifecycle/...andgo vet ./clifecycle/...passMade with Cursor