chore: pin celeris main (1f3b43f) — picks up the h2c Upgrade regression fix - #324
Merged
Merged
Conversation
…ench server Picks up the h2c Upgrade regression fix (goceleris/celeris#576). The nightly on the previous pin failed on exactly that: kitchen_sink/std drove 3,597 upgrade preambles on both arches and got back not one 101, because #440's stdlib migration silently dropped the RFC 7540 3.2 handshake from the std engine while epoll and io_uring kept it. Property side of that run was already clean -- 71,680 evaluations, zero violations -- so this repin is about re-running the h2c slice against an engine that can actually answer it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up goceleris/celeris#576.
The nightly on the previous pin failed on exactly one thing:
kitchen_sink/std drove 3,597 h2c upgrade preambles on both architectures and got back not one 101. goceleris/celeris#440's stdlib migration had silently dropped the RFC 7540 §3.2 handshake from the std engine while epoll and io_uring kept it, which made the h2c-churn slice vacuous on that engine.The property side of that run was already clean — 71,680 evaluations, zero violations — so this repin is about re-running the h2c slice against an engine that can answer it.
All ten modules build for linux/amd64 against the new pin.