Skip to content

Follow-ups from docs#77: stale line locators next to the edited shutdown text, and the uncommitted docs probe #779

Description

@FumingPower3925

Follow-ups from the review of goceleris/docs#77 (#738's docs PR). None blocks the merge. The blocking findings were fixed in docs#77 round 2.

Handled in round 2:

  • "a Start stopped by Shutdown" was not measured (nit). Round 1's probe only started servers with StartWithContext. The round-2 probe measures Start + direct Shutdown too, reading every call's return concurrently. Round 1's probe read Start's return only after Shutdown had returned, which is how the false std claim got in.

Open:

  1. Stale line-number locators next to the edited text. Cite symbols, as the rest of graceful-shutdown.md now does:
  2. The FAQ numbers come from a probe that is not committed anywhere public. round2/738/docs_probe_linux_test.go lives in the lane's evidence root, which is not version-controlled, so nobody else can re-run it from the PR. Commit it (a docs-verification test in probatorium, or an example test in celeris), or say in the page that the numbers are maintainer-measured.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions