Follow-ups from the review of goceleris/docs#77 (#738's docs PR). None blocks the merge. The blocking findings were fixed in docs#77 round 2.
Handled in round 2:
- "a
Start stopped by Shutdown" was not measured (nit). Round 1's probe only started servers with StartWithContext. The round-2 probe measures Start + direct Shutdown too, reading every call's return concurrently. Round 1's probe read Start's return only after Shutdown had returned, which is how the false std claim got in.
Open:
- Stale line-number locators next to the edited text. Cite symbols, as the rest of graceful-shutdown.md now does:
- The FAQ numbers come from a probe that is not committed anywhere public.
round2/738/docs_probe_linux_test.go lives in the lane's evidence root, which is not version-controlled, so nobody else can re-run it from the PR. Commit it (a docs-verification test in probatorium, or an example test in celeris), or say in the page that the numbers are maintainer-measured.
Follow-ups from the review of goceleris/docs#77 (#738's docs PR). None blocks the merge. The blocking findings were fixed in docs#77 round 2.
Handled in round 2:
Startstopped byShutdown" was not measured (nit). Round 1's probe only started servers withStartWithContext. The round-2 probe measuresStart+ directShutdowntoo, reading every call's return concurrently. Round 1's probe readStart's return only afterShutdownhad returned, which is how the false std claim got in.Open:
celeris/server.go:681-699forStartWithListener, and its sentence there does not mention that since fix(server): a Start that never serves releases the caller's listener, the CPU monitor and the settle re-opener (#737) #747 a failed start closes the listener.celeris/server.go:693-751.celeris/resource/config.go:152-161for the Addr/Listener ambiguity check, which is atresource/config.go:216-225at fix(server): Shutdown runs the OnShutdown hooks, and returns, only after the drain on every engine (#703) #746/fix(server): a Start that never serves releases the caller's listener, the CPU monitor and the settle re-opener (#737) #747's heads.grep -c 'server.go:[0-9]'gives deployment.md 4, configuration.md 6. configuration.md also cites manyconfig.go:andresource/config.go:ranges. Follow-ups from docs#73: the graceful-shutdown pages say a cancel behaves identically on every engine, and that ShutdownTimeout bounds only the hooks #738 item 3 named graceful-shutdown.md only, so this is new scope.round2/738/docs_probe_linux_test.golives in the lane's evidence root, which is not version-controlled, so nobody else can re-run it from the PR. Commit it (a docs-verification test in probatorium, or an example test in celeris), or say in the page that the numbers are maintainer-measured.