Fixup transition model generator for namespaced models#555
Merged
JoeSouthan merged 4 commits intomasterfrom Sep 5, 2025
Merged
Fixup transition model generator for namespaced models#555JoeSouthan merged 4 commits intomasterfrom
JoeSouthan merged 4 commits intomasterfrom
Conversation
Fixes #460 Namespaced models were not having their transition class generated correctly.
Tabby
reviewed
Sep 5, 2025
Tabby
reviewed
Sep 5, 2025
Tabby
reviewed
Sep 5, 2025
Tabby
approved these changes
Sep 5, 2025
Contributor
Tabby
left a comment
There was a problem hiding this comment.
Looks good to me. There's potential for a little more refactoring of the templates, but nothing essential
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #460, #546
Namespaced models were not having their transition class generated correctly
Also fixes issue where the model is created after the migration.
Output: