Improve memOutOfBounds precision by being relational w.r.t. size and offset#2058
Open
sim642 wants to merge 11 commits into
Open
Improve memOutOfBounds precision by being relational w.r.t. size and offset#2058sim642 wants to merge 11 commits into
sim642 wants to merge 11 commits into
Conversation
This is just a size query, not the dereference itself. get_addr_size returns `Top for UnknownPtr and that will be checked anyway. Also this has no corresponding safe check, which makes it strange.
This is just an offset query, not the dereference itself.
This is just an offset query, not the dereference itself.
Move some inward to avoid computing unnecessarily. Move some outward (of let*) to compute only once.
sim642
added
sv-comp
michael-schwarz
changed the title
sim642
removed
the
pr-dependency
Member
Author
|
On sv-benchmarks with level02 and 90s, this makes no difference to verdicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #2057.
Previously memOutOfBounds was unnecessarily imprecise: for a points-to set, the sizes of targets and offsets of targets were joined separately, and then bounds were checked on the joined values.
This changes the bounds check to be per-target, without joining sizes and offsets.
It is illustrated by the added test which now passes.