Work around opam bug in make setup for opam < 2.2#2044
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the make setup opam bootstrap flow to avoid an opam < 2.2 bug triggered by --locked when with-dev-setup is present, while keeping the intended locked dependency installation behavior.
Changes:
- Replace
opam switch create . --deps-only ... --lockedwith a two-step workaround: create the local switch with--no-install, then install dependencies from*.opam.locked. - Add inline documentation in
make.shexplaining the opam bug and linking the upstream issue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michael-schwarz
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly build immediately failed after merging #2036.
My guess is that this happens during
make setupwith opam version < 2.2.Although
with-dev-setupwas supposed to be ignored by old opams, it's not with--locked: ocaml/opam#6946.So this is a workaround that should still allow using opam < 2.2.