Bump toolkit off the archived go-iconoir - #16
Merged
Conversation
go-iconoir is archived — its icon data moved to go-icons/iconoir and the rasterising to go-gfx/gfx's svg package — and this module was still reaching it through toolkit v0.202.0. Every module that depends on mvvm inherited that, which is why go-tex/engine and go-embedded-ruby/ruby could not tidy the archived module away on their own: it was not their pin to change. toolkit switched at v0.279.0, so nothing below that is enough. The jump moved one API this module tests: Table.SortColumn and Table.SortAsc are now accessors returning *mvvm.Observable, not fields. That is the MVVM rule applied to the toolkit's own state rather than an incidental rename, so the test reads them through Get() instead of pinning the old shape. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-iconoiris archived: the icon data is now go-icons/iconoir and the rasterising is go-gfx/gfx'ssvgpackage. This module still reached it throughtoolkit v0.202.0, and so did everything depending on mvvm —go-tex/engineandgo-embedded-ruby/rubycannot drop the archived module themselves because the pin is not theirs.toolkit switched at v0.279.0; this goes to v0.288.0.
The jump moves one API the tests use:
Table.SortColumn/SortAscare now accessors returning*mvvm.Observablerather than fields — the MVVM rule applied to the toolkit's own state — so the test reads them throughGet().Verified locally:
gofmtclean,go vetclean, all four packages' tests pass.🤖 Generated with Claude Code