fix: reject non-digit characters in cve validator sequence number - #1611
Open
nikolauspschuetz wants to merge 1 commit into
Open
fix: reject non-digit characters in cve validator sequence number#1611nikolauspschuetz wants to merge 1 commit into
nikolauspschuetz wants to merge 1 commit into
Conversation
nikolauspschuetz
marked this pull request as ready for review
August 23, 2026 14:23
zemzale
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cvevalidator's regex uses[^0](any character except0) in the three leading-zero sequence-number branches, where a non-zero digit[1-9]was intended — every other branch uses\dor[1-9]. So a sequence number containing a non-digit passes validation:A CVE ID's sequence number is decimal digits only (the syntax page linked in the code comment). Replacing
[^0]with[1-9]in the three branches rejects the non-digit cases; the digit-only sequences those branches already matched are unchanged, so the existing tests still pass. Added the non-digit cases toTestCveFormatValidation.