ci(pages): build on pull requests - #3
Merged
Conversation
This workflow ran only on main, so anything opened against this repository arrives with no signal at all -- its checks read "no checks", which is not the same thing as green and must not be merged as if it were. Build on pull_request too. The deploy job is unchanged except that it now runs only for push or workflow_dispatch: a pull request has built the site, which is the whole point of the gate, and it has no business replacing what is served. Verified before pushing: hugo builds this tree locally with the version the workflow pins, so the new gate lands green rather than red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow ran only on main, so anything opened against this repository arrives with no signal at all — its checks read "no checks", which is not the same thing as green and must not be merged as if it were.
Build on
pull_requesttoo.deployis unchanged except that it now runs only forpushorworkflow_dispatch: a pull request has built the site, which is the whole point of the gate, and it has no business replacing what is served.Verified before pushing:
hugo --minifybuilds this tree locally with the version the workflow pins, so the new gate lands green rather than immediately red.Part of a sweep that measured every repository in the fleet with a green default-branch lane: 1000 gate pull requests, 118 did not.