Read the letters those languages use, and stop two ways of hanging - #3
Merged
Conversation
pdffont v0.1.0 -> v0.3.0 and reader v0.4.0 -> v0.4.2.
Four measured defects were being shipped by this package:
- Glyph names covering Czech, Polish, Slovak, Hungarian, Turkish,
Romanian, Latvian and Lithuanian letters mapped to nothing at all, so a
word came back a letter short and still looked like a word. Names
spelling more than one character were refused outright.
- A /ToUnicode map of 10 655 bytes could name 13 million codes: 1 054 MB
and about ten seconds, per font, per page.
- A 219-byte file with no trailer and an object numbered 2 147 483 647
took 21.2 s to open while allocating nothing, so no memory limit
stopped it.
- InlineImage.Expanded walked the image dictionary in one pass, so a
dictionary carrying both spellings of a key -- /W beside /Width -- had
its winner picked by Go's randomised map iteration order. This package
reads inline images, and Images therefore did not agree with itself
from one run to the next.
The first and the last of the four change what this package hands back,
which is the whole of what it is for.
tannevaled
force-pushed
the
bump-pdfkit-deps
branch
from
August 27, 2026 12:57
dd1965b to
18f50ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measurements are being run now and will be added to this body before review.