Catch up with the siblings, and set Renovate to watch them - #5
Merged
Conversation
Two halves of the same problem: this module was behind its own siblings, and nothing was watching. WHAT IT WAS BEHIND ON reader v0.6.0 carries fixes this module was doing without, including two denial of service defects it was handing to its own callers: a 219-byte file with no trailer, whose last object is numbered 2 147 483 647, took 21.2 s to open and allocated not one byte — so no memory limit caught it; /Crypt, which 209 files (12.8% of the 1 633 real government forms) carry and which used to make every one of them decode to nothing readable; a second map-order non-determinism, in indexObjectStreams, giving five different answers in five runs of the same binary on the same file; a damaged stream's decoded prefix kept and labelled as salvage, rather than returned with a nil error as though it were the whole of it. WHY IT HAPPENED, AND WHAT STOPS IT HAPPENING AGAIN Nothing in this organisation was watching for a sibling's release. The org already has a Renovate preset at go-pdfkit/.github, with rules for Go modules and for actions — and not one of the ten Go modules extends it, so the preset has never been read. This adds the one-line renovate.json that does, matching what every go-ruby-* repository already has. That is the durable half. Renovate still has to be installed on the organisation for it to run, which this cannot do from here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tannevaled
force-pushed
the
deps/siblings-current
branch
from
August 27, 2026 18:46
3fa784e to
aff58db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two halves of the same problem: this module was behind its own siblings, and nothing was watching.
WHAT IT WAS BEHIND ON
reader v0.6.0 carries fixes this module was doing without, including two denial
of service defects it was handing to its own callers:
a 219-byte file with no trailer, whose last object is numbered 2 147 483 647,
took 21.2 s to open and allocated not one byte — so no memory limit caught it;
/Crypt, which 209 files (12.8% of the 1 633 real government forms) carry and
which used to make every one of them decode to nothing readable;
a second map-order non-determinism, in indexObjectStreams, giving five
different answers in five runs of the same binary on the same file;
a damaged stream's decoded prefix kept and labelled as salvage, rather than
returned with a nil error as though it were the whole of it.
WHY IT HAPPENED, AND WHAT STOPS IT HAPPENING AGAIN
Nothing in this organisation was watching for a sibling's release. The org
already has a Renovate preset at go-pdfkit/.github, with rules for Go modules
and for actions — and not one of the ten Go modules extends it, so the preset
has never been read. This adds the one-line renovate.json that does, matching
what every go-ruby-* repository already has.
That is the durable half. Renovate still has to be installed on the
organisation for it to run, which this cannot do from here.