Keep the whole of a form when a plan is built, and open a file in time - #2
Merged
Conversation
ops v0.4.0 -> v0.6.0, reader v0.4.0 -> v0.4.2, pdffont -> v0.3.0 indirect. A plan becomes a file through Plan.Build, and the ops release underneath it used to keep a form's widgets while throwing away the field list that gives them meaning: half a form, which is worse than none, because the boxes are still on the page and nothing knows what they are. The same release keeps what a document says about itself -- its language, and the flag saying it was marked up for a screen reader. reader v0.4.2 brings two fixes with it. It walks the objects a file has rather than every number up to the largest of them: a 219-byte file naming object 2 147 483 647 took 21.2 s to open and allocated nothing, so no memory limit caught it. And InlineImage.Expanded no longer lets Go's randomised map iteration order decide between both spellings of a key -- /W beside /Width -- which a page carried through a plan inherits. pdffont is raised with them because it is compiled into this package through ops and forms, and v0.3.0 is where a 10 655-byte /ToUnicode map stops producing 13 million entries and 1 054 MB.
tannevaled
force-pushed
the
bump-pdfkit-deps
branch
from
August 27, 2026 12:57
acbbcc2 to
98e5314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measurements are being run now and will be added to this body before review.