deps: read the ink layer of a scanned page - #13
Closed
tannevaled wants to merge 1 commit into
Closed
Conversation
render v0.11.0 -> v0.14.0, gfx v0.10.0 -> v0.13.0. Three releases had landed
and none of them had reached the app, so none of this was in front of anyone:
render v0.12.0 a scanned page's JPEG 2000 background is drawn
render v0.13.0 a mask that cannot be read takes its image with it, instead
of the ink layer being painted over the page as a solid dark
rectangle
render v0.14.0 JBIG2 is decoded, so the ink layer has its shape; and the
stencil mask is no longer applied inside out, which had every
explicit mask showing the exact complement of itself
gfx v0.13.0 JBIG2 in the codec registry
Measured against poppler on the first page of 25 medical scans, the mean share
of differing pixels goes 0.0083 -> 0.0004 and the worst page 0.1087 -> 0.0004,
with 11 pages improved and none made worse.
100% statement coverage, wasm build, vet on four targets.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #14, which goes to render v0.19.0 and fixes the browser check that could not see a scanned page arrive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three renderer releases had landed and none had reached the app, so none of this was in front of anyone.
Measured against poppler, first page of 25 medical scans:
100% statement coverage, wasm build,
go veton four targets.🤖 Generated with Claude Code