Update CRDs, RBAC, and ServiceMonitor in Helm Chart & Add CI Check for Helm CRDs #112
Open
BonySmoke wants to merge 4 commits into
Open
Update CRDs, RBAC, and ServiceMonitor in Helm Chart & Add CI Check for Helm CRDs #112BonySmoke wants to merge 4 commits into
BonySmoke wants to merge 4 commits into
Conversation
Signed-off-by: Oleh Neichev <oleg.neichev@gmail.com>
Signed-off-by: Oleh Neichev <oleg.neichev@gmail.com>
Signed-off-by: Oleh Neichev <oleg.neichev@gmail.com>
1. Do not scrape Webhook Service since it doesn't expose the /metrics endpoint. 2. Target the metrics port in the Metrics Service using the http scheme instead of https Signed-off-by: Oleh Neichev <oleg.neichev@gmail.com>
BonySmoke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change resolve?
make helm-crdsstatusofTargetresources. This PR adds this configurationmetricsport in the Metrics Service using thehttpscheme instead ofhttpsNote
I didn't bump the chart version because the current version is not yet released.
Also, please let me know if you would like the Helm CRDs CI check to be a separate step in the workflow. I added it along with manifest generation because it felt like an integral part of it.