Skip to content

Mitigate warnings#35

Open
greenozon wants to merge 15 commits into
glmcdona:mainfrom
greenozon:main
Open

Mitigate warnings#35
greenozon wants to merge 15 commits into
glmcdona:mainfrom
greenozon:main

Conversation

@greenozon

@greenozon greenozon commented Jul 12, 2025

Copy link
Copy Markdown

the subject
also some other minor cleanups to make compiler happy..
+memory leaks (mainly in dtors)

@glmcdona

Copy link
Copy Markdown
Owner

Super cool, thanks @greenozon. Will have a closer look through this PR this week.

@greenozon

Copy link
Copy Markdown
Author

Thanks for reply!
there are still like hundred warnings but majority are due to comparing signed/unsigned numbers... (addresses mainly)

@greenozon

greenozon commented Jul 14, 2025

Copy link
Copy Markdown
Author

Current stats as from last commit:

78 warnings for Win32 config (diff modules)
46 warnings for Win64 config (all in a single module - pe_header.cpp)

@greenozon

Copy link
Copy Markdown
Author

The last commit benefits from low memory fragmentation as each & every new/delete does fragment RAM as well as has extra overhead for computation for new/delete operators...
also we do not need delete/delete[] - those sometimes might be omitted (-> memleak) or in case of exception - hard to delete as well.
when we create objects on stack - we have full guarantee that it'll be freed in any case.

@greenozon

Copy link
Copy Markdown
Author

@glmcdona could you please give me a hint here -
image

IMHO the condition should be > 0... ?

@greenozon

Copy link
Copy Markdown
Author

question:

image

seems this option ReconstructHeaderAsDll is never set (did not find any code for setting it to true)
and second point - according to comments it's doing things vice versa?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants