Add Custom Metadata overlay for SDK groups and PropertyDefinition narrowing#101
Open
chinmaya-singal-glean wants to merge 1 commit intohonor-path-level-servers-in-transformerfrom
Open
Conversation
…rowing Stacked on #100 — relies on the transformer fix to produce path keys under /rest/api/index, which is what this overlay's targets are written against. - Groups all 5 Custom Metadata endpoints under indexing.customMetadata in generated SDKs and applies clean method names (upsert, delete, getSchema, upsertSchema, deleteSchema). - Introduces a CustomMetadataPropertyDefinition schema that exposes only name, propertyType, and skipIndexing, and re-points CustomMetadataSchema.metadataKeys.items to it. The shared PropertyDefinition schema (used by the Datasource / Custom Properties API) carries fields that are not relevant to Custom Metadata; we cannot strip them from PropertyDefinition itself without affecting the Indexing API surface. - Registers the overlay in both glean-api-specs and glean-indexing-api-specs. The Custom Metadata endpoints themselves are still x-internal: true upstream in scio. This overlay is a no-op until that flag is removed in Phase 2; landing it here ahead of time so the SDK shape is in place when GA flips. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #100 — depends on the transformer fix landing first so the path keys end up at
/rest/api/index/...(rather than the doubled-prefix variant the transformer currently produces for path-level-server endpoints).indexing.customMetadatain generated SDKs and applies clean method names (upsert,delete,getSchema,upsertSchema,deleteSchema).CustomMetadataPropertyDefinitionschema that exposes onlyname,propertyType, andskipIndexing, and re-pointsCustomMetadataSchema.metadataKeys.itemsto it. The sharedPropertyDefinitionschema (used by the Datasource / Custom Properties API) carries fields likedisplayLabel,displayLabelPlural,uiOptions,hideUiFacet,uiFacetOrder,groupthat are not relevant to Custom Metadata. We can't strip them fromPropertyDefinitionitself without affecting the Indexing API surface, so we narrow via a separate schema.glean-api-specsandglean-indexing-api-specs.Stacking
honor-path-level-servers-in-transformer(Honor path-level servers when prefixing path keys #100)main.Test plan
pnpm test— all tests pass🤖 Generated with Claude Code