Modernization - #9
Open
lordwelch wants to merge 14 commits into
Open
Conversation
Switches to github.com/go-ldap/ldap/v3 for ldap management as it generally has better practices and security
Arranges to start the server before running ldap queries removing flakiness Uses contexts to limit individual command execution time to 100ms Ensure temporary files use the managed t.TempDir() directory Set log output to the test output so that go test has a clean output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a list of modernizations that I don't think would be useful to put into their own PRs. Most of these can be dropped individually without affecting later commits.
Note that this does depend on #8 most of these changes can be done without #8 but will not apply cleanly.